Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go lint issues #4647

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Fix Go lint issues #4647

merged 7 commits into from
Oct 24, 2024

Conversation

jamlo
Copy link
Contributor

@jamlo jamlo commented Oct 22, 2024

After addressing CI false positives, the Lint tests that were failing before are now correctly failing the CI tests.
This PR addresses all the Lint Issues

@jamlo jamlo marked this pull request as ready for review October 22, 2024 20:40
@jamlo jamlo requested review from wdbaruni and frrist October 22, 2024 20:40
Copy link
Member

@wdbaruni wdbaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I am really sorry you had to go through this change. Just minor non-blocking comments

cmd/cli/job/executions.go Outdated Show resolved Hide resolved
pkg/compute/store/boltdb/utils.go Outdated Show resolved Hide resolved
pkg/docker/errors.go Outdated Show resolved Hide resolved
pkg/node/node.go Show resolved Hide resolved
pkg/publicapi/client/v2/client.go Show resolved Hide resolved
pkg/storage/s3/storage.go Show resolved Hide resolved
@jamlo jamlo merged commit 65b51ab into main Oct 24, 2024
7 checks passed
@jamlo jamlo deleted the jamlo/fix-lint-tests branch October 24, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants